Introducing TemporalType#518
Merged
Merged
Conversation
…h additional LocalTime/LocalDateTime types
thepoetdj
changed the title
thepoetdj
changed the title
Member
|
Thanks for this PR! I could only go through it fast today but will see it in detail tomorrow. First impression is that it looks great :) I had to approve the builds and it looks like there's a test failure or something (I haven't had the time to check). Sorry for the late feedback, not sure why I have to approve these runs |
Contributor
Author
Let me have a look at those failed tests. |
Contributor
Author
These should run correctly now. |
Member
|
Looks wonderful, sorry for the long wait! Thanks for implementing this. |
ljacqu
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
This PR introduces a
TemporalTypewith support for following property types:Multiple default formats are provided for each individual property type mentioned above.
TemporalTypeis kept open for the implementation of types that are not provided by default (e.g. YearMonth).Following export rule is followed for each of the property type mentioned above and for any derived types:
convertoperation, otherwiseSupport for these property types is also provided for the bean mapper.